Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix with-firebase-hosting running locally #21971

Merged
merged 4 commits into from Feb 9, 2021
Merged

Fix with-firebase-hosting running locally #21971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
648b52c
Update dependencies, fixes npm run serve
maerzhase Feb 8, 2021
8319267
use latest next and react 17.0.1
maerzhase Feb 9, 2021
8b7f134
never run next in firebase function in dev mode
maerzhase Feb 9, 2021
a09fdde
Merge branch 'canary' into fix/with-firebase-hosting-example
maerzhase Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions examples/with-firebase-hosting/firebaseFunctions.js
View file
Open in desktop
Expand Up @@ -2,11 +2,10 @@ const { join } = require('path')
const { https } = require('firebase-functions')
const { default: next } = require('next')

const isDev = process.env.NODE_ENV !== 'production'
const nextjsDistDir = join('src', require('./src/next.config.js').distDir)

const nextjsServer = next({
dev: isDev,
dev: false,
leerob marked this conversation as resolved.
Show resolved Hide resolved
conf: {
distDir: nextjsDistDir,
},
Expand Down
14 changes: 7 additions & 7 deletions examples/with-firebase-hosting/package.json
View file
Open in desktop
Expand Up @@ -13,15 +13,15 @@
"logs": "firebase functions:log"
},
"dependencies": {
"firebase-admin": "^8.9.0",
"firebase-functions": "^3.3.0",
"next": "^9.3.4",
"react": "^16.13.1",
"react-dom": "^16.13.1"
"firebase-admin": "^9.4.2",
"firebase-functions": "^3.13.1",
"next": "latest",
"react": "^17.0.1",
"react-dom": "^17.0.1"
},
"devDependencies": {
"firebase-functions-test": "^0.1.6",
"firebase-tools": "^8.6.0"
"firebase-functions-test": "^0.2.3",
"firebase-tools": "^9.3.0"
},
"license": "MIT"
}