Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move next/script to pages/_app in script loader integration tests #27626

Merged
merged 1 commit into from Aug 3, 2021

Conversation

stefanprobst
Copy link
Contributor

the integration tests for next/script currently import the Script component in pages/_document.js. according to docs however, next/script "should not be used in pages/_document.js" but in pages/_app.js.

this pr moves next/script from pages/_document to pages/_app - at least locally the script-loader tests still pass. @janicklas-ralph does this make sense?

this would unblock #27257

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member

ijjk commented Jul 30, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary stefanprobst/next.js fix/script-loader-tests Change
buildDuration 12.5s 12.4s -84ms
buildDurationCached 2.9s 3s ⚠️ +56ms
nodeModulesSize 50.3 MB 50.3 MB ⚠️ +4 B
Page Load Tests Overall increase ✓
vercel/next.js canary stefanprobst/next.js fix/script-loader-tests Change
/ failed reqs 0 0
/ total time (seconds) 2.217 2.23 ⚠️ +0.01
/ avg req/sec 1127.62 1120.95 ⚠️ -6.67
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.252 1.193 -0.06
/error-in-render avg req/sec 1996.3 2095.93 +99.63
Client Bundles (main, webpack, commons)
vercel/next.js canary stefanprobst/next.js fix/script-loader-tests Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 22.8 kB 22.8 kB
webpack-HASH.js gzip 1.5 kB 1.5 kB
Overall change 66.7 kB 66.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary stefanprobst/next.js fix/script-loader-tests Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary stefanprobst/next.js fix/script-loader-tests Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 903 B 903 B
image-HASH.js gzip 4.1 kB 4.1 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.8 kB 12.8 kB
Client Build Manifests
vercel/next.js canary stefanprobst/next.js fix/script-loader-tests Change
_buildManifest.js gzip 490 B 490 B
Overall change 490 B 490 B
Rendered Page Sizes
vercel/next.js canary stefanprobst/next.js fix/script-loader-tests Change
index.html gzip 530 B 530 B
link.html gzip 542 B 542 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary stefanprobst/next.js fix/script-loader-tests Change
buildDuration 10.2s 10.1s -110ms
buildDurationCached 4s 3.9s -10ms
nodeModulesSize 50.3 MB 50.3 MB ⚠️ +4 B
Page Load Tests Overall increase ✓
vercel/next.js canary stefanprobst/next.js fix/script-loader-tests Change
/ failed reqs 0 0
/ total time (seconds) 2.237 2.152 -0.08
/ avg req/sec 1117.54 1161.46 +43.92
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.247 1.268 ⚠️ +0.02
/error-in-render avg req/sec 2005.45 1972.23 ⚠️ -33.22
Client Bundles (main, webpack, commons)
vercel/next.js canary stefanprobst/next.js fix/script-loader-tests Change
17.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 13.8 kB 13.8 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.7 kB 67.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary stefanprobst/next.js fix/script-loader-tests Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary stefanprobst/next.js fix/script-loader-tests Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.74 kB 3.74 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.94 kB 2.94 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.7 kB 17.7 kB
Client Build Manifests
vercel/next.js canary stefanprobst/next.js fix/script-loader-tests Change
_buildManifest.js gzip 499 B 499 B
Overall change 499 B 499 B
Rendered Page Sizes
vercel/next.js canary stefanprobst/next.js fix/script-loader-tests Change
index.html gzip 578 B 578 B
link.html gzip 591 B 591 B
withRouter.html gzip 571 B 571 B
Overall change 1.74 kB 1.74 kB
Commit: a70ccad

@timneutkens timneutkens merged commit 5ded742 into vercel:canary Aug 3, 2021
@stefanprobst stefanprobst deleted the fix/script-loader-tests branch August 3, 2021 15:29
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants