Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS type conflict for <img> tag #28672

Merged
merged 1 commit into from Aug 31, 2021
Merged

Conversation

styfle
Copy link
Member

@styfle styfle commented Aug 31, 2021

This type was added in PR #28269 but doesn't need to be public and was causing conflicts with @types/react@17.

We currently use @types/react@16 so ideally we should upgrade to @types/react@17 and then remove the ts-ignore.

Fixes #28647

@ijjk
Copy link
Member

ijjk commented Aug 31, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js remove-loading-prop-conflict Change
buildDuration 12.4s 12.4s ⚠️ +28ms
buildDurationCached 2.9s 2.8s -58ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +6 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js remove-loading-prop-conflict Change
/ failed reqs 0 0
/ total time (seconds) 2.259 2.185 -0.07
/ avg req/sec 1106.58 1144.16 +37.58
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.257 1.26 0
/error-in-render avg req/sec 1988.76 1984.74 ⚠️ -4.02
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js remove-loading-prop-conflict Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.3 kB 23.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 67.2 kB 67.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js remove-loading-prop-conflict Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js remove-loading-prop-conflict Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary vercel/next.js remove-loading-prop-conflict Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js remove-loading-prop-conflict Change
index.html gzip 540 B 540 B
link.html gzip 551 B 551 B
withRouter.html gzip 534 B 534 B
Overall change 1.63 kB 1.63 kB

Diffs

Diff for _buildManifest.js
@@ -17,7 +17,7 @@ self.__BUILD_MANIFEST = {
     "static\u002Fchunks\u002Fpages\u002Fhooks-f6efb8a484d4a96e150c.js"
   ],
   "/image": [
-    "static\u002Fchunks\u002Fpages\u002Fimage-44a80ed2baebfb52799e.js"
+    "static\u002Fchunks\u002Fpages\u002Fimage-9ff7c92fe6c596bfb486.js"
   ],
   "/link": ["static\u002Fchunks\u002Fpages\u002Flink-f62bdaa581311495bb85.js"],
   "/routerDirect": [
Diff for image-HASH.js
@@ -680,6 +680,7 @@
                   "data-nimg": layout,
                   style: imgStyle,
                   className: className,
+                  // @ts-ignore - TODO: upgrade to `@types/react@17`
                   loading: loading || "lazy"
                 }
               )

Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js remove-loading-prop-conflict Change
buildDuration 10.3s 10.2s -89ms
buildDurationCached 4.5s 4.4s -60ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +6 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js remove-loading-prop-conflict Change
/ failed reqs 0 0
/ total time (seconds) 2.372 2.32 -0.05
/ avg req/sec 1053.8 1077.39 +23.59
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.257 1.252 0
/error-in-render avg req/sec 1989.64 1997.41 +7.77
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js remove-loading-prop-conflict Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.7 kB 10.7 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68.1 kB 68.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js remove-loading-prop-conflict Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js remove-loading-prop-conflict Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.03 kB 3.03 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js remove-loading-prop-conflict Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js remove-loading-prop-conflict Change
index.html gzip 585 B 585 B
link.html gzip 598 B 598 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: eb58264

@kodiakhq kodiakhq bot merged commit acf65f9 into canary Aug 31, 2021
@kodiakhq kodiakhq bot deleted the remove-loading-prop-conflict branch August 31, 2021 19:03
balazsorban44 added a commit to nextauthjs/next-auth that referenced this pull request Sep 5, 2021
@kevinsimper
Copy link

This would be really nice to get out 😄

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants