Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TS type conflict for <img> tag #28672

Merged
merged 1 commit into from Aug 31, 2021
Merged

Fix TS type conflict for <img> tag #28672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/next/client/image.tsx
View file
Open in desktop
Expand Up @@ -627,6 +627,7 @@ export default function Image({
data-nimg={layout}
style={imgStyle}
className={className}
// @ts-ignore - TODO: upgrade to `@types/react@17`
loading={loading || 'lazy'}
/>
</noscript>
Expand Down
5 changes: 0 additions & 5 deletions packages/next/types/index.d.ts
View file
Open in desktop
Expand Up @@ -40,11 +40,6 @@ declare module 'react' {
interface LinkHTMLAttributes<T> extends HTMLAttributes<T> {
nonce?: string
}

// <img loading="lazy"> support
interface ImgHTMLAttributes<T> extends HTMLAttributes<T> {
loading?: 'auto' | 'eager' | 'lazy'
}
}

export type Redirect =
Expand Down