-
Notifications
You must be signed in to change notification settings - Fork 26k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure NEXT_DYNAMIC_NO_SSR_CODE has a unique name #50219
Merged
ijjk
merged 3 commits into
canary
from
05-23-Ensure_NEXT_DYNAMIC_NO_SSR_CODE_has_a_unique_name
May 23, 2023
Merged
Ensure NEXT_DYNAMIC_NO_SSR_CODE has a unique name #50219
ijjk
merged 3 commits into
canary
from
05-23-Ensure_NEXT_DYNAMIC_NO_SSR_CODE_has_a_unique_name
May 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
requested review from
ijjk,
shuding,
huozhi and
feedthejim
as code owners
May 23, 2023 14:50
ijjk
added
area: tests
created-by: Next.js team
PRs by the Next.js team
type: next
labels
May 23, 2023
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
huozhi
approved these changes
May 23, 2023
ijjk
approved these changes
May 23, 2023
1 task
hydRAnger
pushed a commit
to hydRAnger/next.js
that referenced
this pull request
Jun 12, 2023
## What? Ensures `NEXT_DYNAMIC_NO_SSR_CODE` has a unique error code value, this accidentally had the value for dynamic server usage (e.g. calling cookies()) which caused the warning to be shown as shown in vercel#48442. ## How? Changed the digest value to something unique. Fixes NEXT-1125 Fixes vercel#48442 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ensures
NEXT_DYNAMIC_NO_SSR_CODE
has a unique error code value, this accidentally had the value for dynamic server usage (e.g. calling cookies()) which caused the warning to be shown as shown in #48442.How?
Changed the digest value to something unique.
Fixes NEXT-1125
Fixes #48442