Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ts type generation #2038

Merged
merged 3 commits into from Jun 24, 2022
Merged

Fix ts type generation #2038

merged 3 commits into from Jun 24, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jun 18, 2022

Fixes #2037

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 18, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f93e88d:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration

@huozhi huozhi marked this pull request as ready for review June 18, 2022 15:50
@huozhi huozhi requested a review from shuding as a code owner June 18, 2022 15:50
@shuding
Copy link
Member

shuding commented Jun 19, 2022

Worth adding a test case?

@huozhi
Copy link
Member Author

huozhi commented Jun 20, 2022

Current test suites are hard to cover the generated types testing. We can do it later

@shuding shuding merged commit 518ce25 into main Jun 24, 2022
@shuding shuding deleted the fix/type-gen branch June 24, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SWRConfig's value type is any
2 participants