Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: isLoading and isValidating should always respect cache value #2048

Merged
merged 2 commits into from Jun 24, 2022
Merged

fix: isLoading and isValidating should always respect cache value #2048

merged 2 commits into from Jun 24, 2022

Conversation

promer94
Copy link
Collaborator

@promer94 promer94 commented Jun 24, 2022 •
edited

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 24, 2022 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6a98931:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration
swr #2030 PR

shuding
shuding reviewed Jun 24, 2022
View reviewed changes
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, can you create a test case based on that reproduction?

@shuding shuding merged commit 5b3af2b into vercel:main Jun 24, 2022
@promer94 promer94 deleted the fixloading branch June 24, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuding shuding shuding left review comments

@huozhi huozhi huozhi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isLoading: wrong state
3 participants
@promer94 @shuding @huozhi