Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: isLoading and isValidating should always respect cache value #2048

Merged
merged 2 commits into from
Jun 24, 2022
Merged

fix: isLoading and isValidating should always respect cache value #2048

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4eebfa8
fix: isLoading and isValidating should always respect cache value
promer94 Jun 24, 2022
6a98931
test: case for #2030
promer94 Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/use-swr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,8 @@ export const useSWRHandler = <Data = any, Error = any>(
isInitialMount &&
shouldDoInitialRevalidation
)
const isValidating = cached.isValidating || defaultValidatingState
const isLoading = cached.isLoading || defaultValidatingState
const isValidating = isUndefined(cached.isValidating) ? defaultValidatingState : cached.isValidating
const isLoading = isUndefined(cached.isLoading) ? defaultValidatingState : cached.isLoading

// The revalidation function is a carefully crafted wrapper of the original
// `fetcher`, to correctly handle the many edge cases.
Expand Down