Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix on design-system example #7885

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

zsh77
Copy link
Contributor

@zsh77 zsh77 commented Apr 2, 2024

Description

  • add preview-storybook task to turbo.json and it's script in the root's package.json
  • improvement on clean script
  • changed the tsup config of @acme/ui package not to make source map files in order to match the content of ui/dist directory stated in README of root
  • bug fix of README file. Replaced acme-core and other names that meant to point to packages/ui with @acme/ui

Testing Instructions

Running npx create-turbo@latest -e design-system and then pnpm dev should work and start storybook in dev mode. README.md file in the root should be fine too.

@zsh77 zsh77 requested review from anthonyshew and a team as code owners April 2, 2024 16:08
@zsh77 zsh77 requested a review from NicholasLYang April 2, 2024 16:08
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples owned-by: turborepo labels Apr 2, 2024
Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 11:28pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 11:28pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 11:28pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 11:28pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 11:28pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 11:28pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 11:28pm

Copy link

vercel bot commented Apr 2, 2024

@zsh77 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ijjk
Copy link
Member

ijjk commented Apr 2, 2024

Allow CI Workflow Run

  • approve CI run for commit: 6331bb5

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@zsh77 zsh77 changed the title Improvement on design system bug fix on design-system Apr 8, 2024
@zsh77
Copy link
Contributor Author

zsh77 commented May 6, 2024

@anthonyshew I'm just making sure in case you've missed this PR. Thank you in advance for your review!

@du5rte
Copy link

du5rte commented May 10, 2024

A lot of the examples are broken. I applied this PR changes over npx create-turbo@latest -e design-system and worked like a charm. Thank you @zsh77 !

@zsh77
Copy link
Contributor Author

zsh77 commented May 10, 2024

A lot of the examples are broken. I applied this PR changes over npx create-turbo@latest -e design-system and worked like a charm. Thank you @zsh77 !

Happy it helped you @du5rte !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage owned-by: turborepo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants