Docs(deploying-with-docker.mdx): Inform user about turbo prune command
#7948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command `turbo prune web --docker` produces an error if the name in the package.json is not set to web
```
{
name: "nextjs-app"
}
```
It will then throw the error: `package web not found`. This change informs the user that it is being assumed that the name given in the package.json is "web".
turbo-orchestrator
bot
added
area: docs
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@WillKirkmanM is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
chris-olszewski
pushed a commit
that referenced
this pull request
Apr 15, 2024
) ### Description Related to #7948, in running the `turbo prune` when specifying a package name, it is assumed that the package name is the name of the **folder** in `apps/web` or `packages/eslint-config`. The real case is that the package name is the name found in the `package.json` file in the `apps/*` directory.  This pull requests adds more detail and clarity towards the uncertainty of defining what the package means. **Files Edited** Line 46 of https://github.com/vercel/turbo/blob/main/crates/turborepo-lib/src/commands/prune.rs ```rs #[error("invalid scope: package {0} not found")] MissingWorkspace(PackageName), ``` to ```rs #[error("invalid scope: package with name {0} in package.json not found")] MissingWorkspace(PackageName), ```
WillKirkmanM
changed the title
turbo prune commandturbo prune command
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
anthonyshew
approved these changes
Apr 22, 2024
This was referenced May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The command
turbo prune web --dockerproduces an error if the name in the package.json is not set to web, for example:It will then throw the error:
package web not found. This change informs the user that it is being assumed that the name given in the package.json is "web".Testing Instructions
web,next-appfor example.docker-compose uppackage web not foundRUN turbo prune web --dockertoRUN turbo prune next-app --dockerdocker-compose up