feat(turborepo): new ui + watch mode #7962

NicholasLYang · 2024-04-15T16:03:44Z

Description

Integrates new UI with watch mode. Pulls out the UI handle and sender outside the Visitor and Run struct, so it can be owned by the WatchClient. Also adds an Event for updating the task names, so on rediscovery we can keep using the same UI thread but just update the task names.

Testing Instructions

Give it a shot!

Closes TURBO-2801

NicholasLYang · 2024-04-15T16:03:52Z

feat(turborepo): new ui + watch mode #7962 👈
feat(turborepo): Persistent Tasks in Watch Mode #7922 : 1 other dependent PR (#8016 )
feat(turborepo): Watch mode #7613 : 1 other dependent PR (#7898 )
feat(turborepo): Package Change Watching #7570
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NicholasLYang and the rest of your teammates on Graphite

vercel · 2024-04-15T16:03:54Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
examples-nonmonorepo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 10, 2024 9:55pm
examples-svelte-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	May 10, 2024 9:55pm
rust-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 10, 2024 9:55pm
turbo-turbo-tracing-next-plugin	❌ Failed (Inspect)			May 10, 2024 9:55pm

7 Ignored Deployments

Name	Status	Preview	Updated (UTC)
examples-basic-web	⬜️ Ignored (Inspect)	Visit Preview	May 10, 2024 9:55pm
examples-designsystem-docs	⬜️ Ignored (Inspect)	Visit Preview	May 10, 2024 9:55pm
examples-gatsby-web	⬜️ Ignored (Inspect)	Visit Preview	May 10, 2024 9:55pm
examples-kitchensink-blog	⬜️ Ignored (Inspect)	Visit Preview	May 10, 2024 9:55pm
examples-native-web	⬜️ Ignored (Inspect)	Visit Preview	May 10, 2024 9:55pm
examples-tailwind-web	⬜️ Ignored (Inspect)	Visit Preview	May 10, 2024 9:55pm
examples-vite-web	⬜️ Ignored (Inspect)	Visit Preview	May 10, 2024 9:55pm

github-actions · 2024-04-15T16:04:32Z

🟢 Turbopack Benchmark CI successful 🟢

Thanks

github-actions · 2024-04-15T16:20:15Z

⚠️ CI failed ⚠️

The following steps have failed in CI:

Turborepo Rust checks

See workflow summary for details

…in the table

chris-olszewski

Overall this looks good, primarily concerned with testing the state machine that is our UI.

chris-olszewski · 2024-05-10T20:13:58Z

crates/turborepo-ui/src/tui/task.rs

        self.state.start
    }
+    pub fn start(self) -> Task<Running> {


This feels off, do we want to start running tasks again vs creating a new task and having it go through the natural progression of planned -> running -> finished?

Ahh yeah that makes more sense

chris-olszewski · 2024-05-10T20:27:19Z

crates/turborepo-ui/src/tui/app.rs

@@ -77,6 +77,10 @@ impl<I> App<I> {
    pub fn term_size(&self) -> (u16, u16) {
        self.pane.term_size()
    }
+
+    pub fn update_tasks(&mut self, tasks: Vec<String>) {
+        self.table = TaskTable::new(tasks.clone());


We need to be clearing and updating the panes in some way as well. Right now they get reused so task output from a previous run is still displayed.

Is that bad? I kind of like seeing the previous runs, so you can understand that something got re-run. If a task completes too quickly, it could end up showing the same output which would confuse people

crates/turborepo-ui/src/tui/handle.rs

chris-olszewski · 2024-05-10T20:36:57Z

crates/turborepo-ui/src/tui/app.rs

@@ -77,6 +77,10 @@ impl<I> App<I> {
    pub fn term_size(&self) -> (u16, u16) {
        self.pane.term_size()
    }
+
+    pub fn update_tasks(&mut self, tasks: Vec<String>) {
+        self.table = TaskTable::new(tasks.clone());


Due to a prior hack, there should be self.next() as otherwise the table might be out of sync with the pane. i.e. display wrong pane for selected task in table

chris-olszewski · 2024-05-10T20:47:30Z

crates/turborepo-ui/src/tui/table.rs

+                    self.scroll.select(Some(selected_idx + 1));
+                }
+            }
+        } else {


So if a task gets restarted while it's still running it will error?

That's currently not possible. We purposefully make it so the same task can't be run at the same time, and we haven't implemented cancelation logic. If a change event happens in the middle of a run, we save it and wait for the run to finish before starting up a new execution.

chris-olszewski · 2024-05-10T20:54:30Z

crates/turborepo-ui/src/tui/table.rs

+            .iter()
+            .position(|finished_task| finished_task.name() == task)
+        {
+            let finished = self.finished.remove(finished_idx);


I think some unit tests would be a good fit here.

Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>

NicholasLYang mentioned this pull request Apr 15, 2024

feat(turborepo): Watch mode #7613

Merged

turbo-orchestrator bot added created-by: turborepo owned-by: turborepo labels Apr 15, 2024

NicholasLYang mentioned this pull request Apr 15, 2024

feat(turborepo): Package Change Watching #7570

Merged

This was referenced Apr 15, 2024

feat: Re-run dependent tasks in watch mode #7898

Merged

feat(turborepo): Persistent Tasks in Watch Mode #7922

Merged

vercel bot deployed to Preview – examples-nonmonorepo April 15, 2024 16:04 View deployment

vercel bot deployed to Preview – rust-docs April 15, 2024 16:14 View deployment

NicholasLYang force-pushed the nicholasyang/persistent-tasks branch from 0d4f68d to 02a5e85 Compare April 16, 2024 14:54

NicholasLYang force-pushed the nicholasyang/watch-with-experimental-ui branch from 09b44be to c090c69 Compare April 16, 2024 14:54

vercel bot deployed to Preview – examples-nonmonorepo April 16, 2024 14:55 View deployment

vercel bot had a problem deploying to Preview – turbo-turbo-tracing-next-plugin April 16, 2024 14:58 Failure

vercel bot deployed to Preview – rust-docs April 16, 2024 15:05 View deployment

NicholasLYang force-pushed the nicholasyang/persistent-tasks branch from 02a5e85 to 24a0c13 Compare April 17, 2024 19:22

NicholasLYang force-pushed the nicholasyang/watch-with-experimental-ui branch from c090c69 to 2050124 Compare April 17, 2024 19:22

vercel bot deployed to Preview – examples-nonmonorepo April 17, 2024 19:23 View deployment

vercel bot deployed to Preview – rust-docs April 17, 2024 19:33 View deployment

NicholasLYang force-pushed the nicholasyang/persistent-tasks branch from 8931497 to 2152b42 Compare April 18, 2024 17:11

NicholasLYang force-pushed the nicholasyang/watch-with-experimental-ui branch from 2050124 to c69ac3a Compare April 18, 2024 17:11

vercel bot deployed to Preview – examples-nonmonorepo April 18, 2024 17:11 View deployment

NicholasLYang force-pushed the nicholasyang/persistent-tasks branch from 2152b42 to 84b3416 Compare April 18, 2024 17:18

NicholasLYang force-pushed the nicholasyang/watch-with-experimental-ui branch from c69ac3a to e8ceb6f Compare April 18, 2024 17:19

vercel bot deployed to Preview – examples-nonmonorepo April 18, 2024 17:19 View deployment

vercel bot deployed to Preview – rust-docs April 18, 2024 17:31 View deployment

NicholasLYang force-pushed the nicholasyang/persistent-tasks branch from 84b3416 to 232f44d Compare April 19, 2024 16:20

NicholasLYang force-pushed the nicholasyang/watch-with-experimental-ui branch from e8ceb6f to 53a852f Compare April 19, 2024 16:20

vercel bot deployed to Preview – rust-docs April 19, 2024 18:24 View deployment

NicholasLYang force-pushed the nicholasyang/persistent-tasks branch from cdb7ad4 to f916053 Compare April 19, 2024 19:13

NicholasLYang force-pushed the nicholasyang/watch-with-experimental-ui branch from 09c0e0d to fd3c6d1 Compare April 19, 2024 19:13

vercel bot deployed to Preview – examples-nonmonorepo April 19, 2024 19:14 View deployment

vercel bot deployed to Preview – rust-docs April 19, 2024 19:23 View deployment

NicholasLYang force-pushed the nicholasyang/persistent-tasks branch from 8b2029b to 5c639c5 Compare April 22, 2024 16:00

NicholasLYang mentioned this pull request Apr 22, 2024

chore: Improved errors for watch mode #8016

Merged

Base automatically changed from nicholasyang/persistent-tasks to main April 23, 2024 21:24

NicholasLYang force-pushed the nicholasyang/watch-with-experimental-ui branch from fd3c6d1 to fe028d0 Compare May 10, 2024 17:10

vercel bot deployed to Preview – examples-nonmonorepo May 10, 2024 17:10 View deployment

vercel bot deployed to Preview – rust-docs May 10, 2024 17:20 View deployment

Trying to get experimental UI working with watch mode

78937d6

NicholasLYang force-pushed the nicholasyang/watch-with-experimental-ui branch from fe028d0 to 78937d6 Compare May 10, 2024 17:38

vercel bot deployed to Preview – examples-nonmonorepo May 10, 2024 17:39 View deployment

vercel bot deployed to Preview – rust-docs May 10, 2024 17:49 View deployment

Finished connecting to new UI. Added an event for updating the tasks …

19a6a64

…in the table

NicholasLYang changed the title ~~Trying to get experimental UI working with watch mode~~ feat(turborepo): new ui + watch mode May 10, 2024

vercel bot deployed to Preview – examples-nonmonorepo May 10, 2024 19:23 View deployment

NicholasLYang marked this pull request as ready for review May 10, 2024 19:26

NicholasLYang requested a review from a team as a code owner May 10, 2024 19:26

NicholasLYang requested review from tknickman and paulogdm May 10, 2024 19:26

vercel bot deployed to Preview – rust-docs May 10, 2024 19:33 View deployment

Fix clippy

e32a3ad

vercel bot deployed to Preview – examples-nonmonorepo May 10, 2024 20:22 View deployment

vercel bot deployed to Preview – rust-docs May 10, 2024 20:32 View deployment

chris-olszewski requested changes May 10, 2024

View reviewed changes

Update crates/turborepo-ui/src/tui/handle.rs

caa62ad

Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>

vercel bot deployed to Preview – examples-nonmonorepo May 10, 2024 21:45 View deployment

vercel bot deployed to Preview – rust-docs May 10, 2024 21:55 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(turborepo): new ui + watch mode #7962

feat(turborepo): new ui + watch mode #7962

NicholasLYang commented Apr 15, 2024 •

edited

NicholasLYang commented Apr 15, 2024 •

edited

vercel bot commented Apr 15, 2024 •

edited

github-actions bot commented Apr 15, 2024 •

edited

github-actions bot commented Apr 15, 2024 •

edited

chris-olszewski left a comment

chris-olszewski May 10, 2024

NicholasLYang May 10, 2024

chris-olszewski May 10, 2024

NicholasLYang May 10, 2024

chris-olszewski May 10, 2024

chris-olszewski May 10, 2024

NicholasLYang May 10, 2024

chris-olszewski May 10, 2024

feat(turborepo): new ui + watch mode #7962

Are you sure you want to change the base?

feat(turborepo): new ui + watch mode #7962

Conversation

NicholasLYang commented Apr 15, 2024 • edited

Description

Testing Instructions

NicholasLYang commented Apr 15, 2024 • edited

vercel bot commented Apr 15, 2024 • edited

github-actions bot commented Apr 15, 2024 • edited

🟢 Turbopack Benchmark CI successful 🟢

github-actions bot commented Apr 15, 2024 • edited

⚠️ CI failed ⚠️

chris-olszewski left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NicholasLYang commented Apr 15, 2024 •

edited

NicholasLYang commented Apr 15, 2024 •

edited

vercel bot commented Apr 15, 2024 •

edited

github-actions bot commented Apr 15, 2024 •

edited

github-actions bot commented Apr 15, 2024 •

edited