chore(ci): breakup GH test.yml #8027
Open
+639
−442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
turbopack and turborepo tests are often blocking each other and there is no good reason to keep them all in one workflow. This PR separates them. Since linting and JS packages are not cleanly separated between the projects, they get their own workflows as well
mehulkar
force-pushed
the
mk/breakup-test
branch
from
85941b8
to
987fe97
Compare
mehulkar
commented
Apr 24, 2024
mehulkar
commented
Apr 24, 2024
| uses: ./.github/actions/setup-turborepo-environment | ||
| with: | ||
| github-token: "${{ secrets.GITHUB_TOKEN }}" | ||
| node-version: "20" |
There was a problem hiding this comment.
at some point we'll add node 18 to this matrix, JS packages should work on node 18
tknickman
reviewed
Apr 24, 2024
I think the required check thing is handled by the "Determine Jobs" job in each one. IIUC, any job that is a required check and only runs on some paths needs this handling. All the broken up workflows are duplicating that logic, so there's a final |
wbinnssmith
reviewed
May 10, 2024
| run: | | ||
| cargo groups clippy turborepo-libraries --features rustls-tls -- --deny clippy::all | ||
|
|
||
| - name: Run ast-grep lints |
There was a problem hiding this comment.
Is this accounted for in Turbopack still?
wbinnssmith
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
turbopack and turborepo tests are often blocking each other and
there is no good reason to keep them all in one workflow. This
PR separates them. Since linting and JS packages are not cleanly
separated between the projects, they get their own workflows as well
Closes TURBO-2868