add two retry strategies to allow requests to timeout gracefully #8080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
This was referenced May 3, 2024
🟢 Turbopack Benchmark CI successful 🟢Thanks |
arlyon
requested review from
Zertsov and
NicholasLYang
and removed request for
a team
🟢 CI successful 🟢Thanks |
arlyon
force-pushed
the
arlyon/cache-timeout-warning
branch
from
c42a40a
to
5be570d
Compare
arlyon
force-pushed
the
arlyon/cache-retry-strategy
branch
from
4477bec
to
fe23c35
Compare
arlyon
force-pushed
the
arlyon/cache-timeout-warning
branch
from
5be570d
to
f44feba
Compare
arlyon
force-pushed
the
arlyon/cache-retry-strategy
branch
from
fe23c35
to
f0f9ea3
Compare
NicholasLYang
approved these changes
May 15, 2024
arlyon
force-pushed
the
arlyon/cache-retry-strategy
branch
from
f0f9ea3
to
6130f00
Compare
arlyon
force-pushed
the
arlyon/cache-retry-strategy
branch
from
6130f00
to
2f5f461
Compare
tknickman
pushed a commit
that referenced
this pull request
May 21, 2024
Certain APIs should time out in different ways. For the cache, we want to retry connection attempts but not retry upload timeouts as a retry is unlikely to change your connection speed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Certain APIs should time out in different ways. For the cache, we want to retry connection attempts but not retry upload timeouts as a retry is unlikely to change your connection speed.
Testing Instructions
New unit tests.
Closes TURBO-2976