add support for upload speed / remaining in the cache upload step #8081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
This was referenced May 3, 2024
This was referenced May 3, 2024
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
arlyon
force-pushed
the
arlyon/cache-retry-strategy
branch
from
4477bec
to
fe23c35
Compare
arlyon
force-pushed
the
arlyon/cache-upload-status
branch
from
81bd6ba
to
6b1fb28
Compare
arlyon
force-pushed
the
arlyon/cache-retry-strategy
branch
from
fe23c35
to
f0f9ea3
Compare
arlyon
force-pushed
the
arlyon/cache-upload-status
branch
from
6b1fb28
to
a6367c9
Compare
arlyon
force-pushed
the
arlyon/cache-upload-status
branch
from
a6367c9
to
f3122ed
Compare
arlyon
commented
May 10, 2024
arlyon
commented
May 10, 2024
arlyon
commented
May 10, 2024
arlyon
force-pushed
the
arlyon/cache-retry-strategy
branch
from
f0f9ea3
to
6130f00
Compare
arlyon
force-pushed
the
arlyon/cache-upload-status
branch
from
23c3965
to
cfb9bd9
Compare
arlyon
force-pushed
the
arlyon/cache-retry-strategy
branch
from
6130f00
to
2f5f461
Compare
arlyon
force-pushed
the
arlyon/cache-upload-status
branch
from
cfb9bd9
to
ba71868
Compare
arlyon
force-pushed
the
arlyon/cache-upload-status
branch
from
ba71868
to
bc29e74
Compare
arlyon
force-pushed
the
arlyon/cache-upload-status
branch
from
bc29e74
to
017454a
Compare
arlyon
requested review from
chris-olszewski and
NicholasLYang
and removed request for
gsoltis and
paulogdm
arlyon
force-pushed
the
arlyon/cache-upload-status
branch
from
017454a
to
61d6e8d
Compare
chris-olszewski
approved these changes
May 21, 2024
arlyon
force-pushed
the
arlyon/cache-upload-status
branch
from
61d6e8d
to
6213948
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When turbo is waiting for the cache, don't really expose any data to the user. This PR modifies the cache put operation to take a stream and introduces a new stream adapter that captures a running history of writes using a ring buffer. These requests are stored in a hashmap which is read by the spinner while waiting for shutdown, and a live number is posted with the remaining bytes and current upload speed.
Also gracefully shuts down the upload phase when pressing ctrl-c
Before:
After:
https://asciinema.org/a/s9AsFiVHQRISc22Ve0YY6IlTQ
Testing Instructions
TBD
Closes TURBO-2977