[node-bridge][build-utils] Add multi payload lambda handling in node-bridge #7507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #7507 +/- ##
=======================================
Coverage 48.57% 48.57%
=======================================
Files 132 132
Lines 5295 5295
Branches 1328 1328
=======================================
Hits 2572 2572
Misses 2710 2710
Partials 13 13 Continue to review full report at Codecov.
|
ijjk
requested review from
styfle,
TooTallNate,
lucleray and
AndyBitz
as code owners
AndyBitz
approved these changes
Mar 3, 2022
styfle
reviewed
Mar 3, 2022
styfle
approved these changes
Mar 4, 2022
4 tasks
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 14, 2022
…7681) ### Related Issues This ensures a content-type is always set inside of each part of the multi-part payload as it's needed for proper parsing. This also ensures non-200 status codes/headers are passed back separate when they differ so that they can be handled independently without assuming they all match. x-ref: https://vercel.slack.com/archives/C03AYHB6MA9 x-ref: #7507 ### 📋 Checklist <!-- Please keep your PR as a Draft until the checklist is complete --> #### Tests - [ ] The code changed/added as part of this PR has been covered with tests - [ ] All tests pass locally with `yarn test-unit` #### Code Review - [ ] This PR has a concise title and thorough description useful to a reviewer - [ ] Issue from task tracker has a link to this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
x-ref: vercel/next.js#34935
📋 Checklist
Tests
yarn test-unitCode Review