[examples] Update next.js boilerplate example #9008
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iteratetograceness
requested review from
timneutkens,
ijjk and
styfle
as code owners
ijjk
reviewed
Dec 5, 2022
| @@ -1,6 +1,7 @@ | |||
| /** @type {import('next').NextConfig} */ | |||
| const nextConfig = { | |||
| reactStrictMode: true, | |||
| swcMinify: true, | |||
There was a problem hiding this comment.
Suggested change
| swcMinify: true, |
This is the default now so we can omit it
There was a problem hiding this comment.
Awesome will do + I'll make a PR to omit this from the create-next-app package templates as well! Also in regards to merging this PR, I think it would be best to hold off until v13.0.7 is officially released -- lmk what you think!
There was a problem hiding this comment.
@ijjk re: @styfle's comment below: ah, looks like this template will update itself once 13.0.7 becomes an official release -- so I'm assuming this PR is not needed!
But I'll still open the PR to omit swcMinify from the create-next-app templates!
cc: @kale-stew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Next.js Boilerplate example with the create-next-app redesign.
Related Issues
Related to vercel/next.js#43482.
馃搵 Checklist
Tests
yarn test-unitCode Review