New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Update next.js boilerplate example #9008
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,7 +30,3 @@ yarn-error.log* | |
|
|
||
| # vercel | ||
| .vercel | ||
|
|
||
| # typescript | ||
| *.tsbuildinfo | ||
| next-env.d.ts | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| /** @type {import('next').NextConfig} */ | ||
| const nextConfig = { | ||
| reactStrictMode: true, | ||
| swcMinify: true, | ||
| } | ||
|
|
||
| module.exports = nextConfig | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,5 @@ | ||
| import '../styles/globals.css' | ||
|
|
||
| function MyApp({ Component, pageProps }) { | ||
| export default function App({ Component, pageProps }) { | ||
| return <Component {...pageProps} /> | ||
| } | ||
|
|
||
| export default MyApp |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import { Html, Head, Main, NextScript } from 'next/document' | ||
|
|
||
| export default function Document() { | ||
| return ( | ||
| <Html lang="en"> | ||
| <Head /> | ||
| <body> | ||
| <Main /> | ||
| <NextScript /> | ||
| </body> | ||
| </Html> | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,71 +1,123 @@ | ||
| import Head from 'next/head' | ||
| import Image from 'next/image' | ||
| import { Inter } from '@next/font/google' | ||
| import styles from '../styles/Home.module.css' | ||
|
|
||
| const inter = Inter({ subsets: ['latin'] }) | ||
|
|
||
| export default function Home() { | ||
| return ( | ||
| <div className={styles.container}> | ||
| <> | ||
| <Head> | ||
| <title>Create Next App</title> | ||
| <meta name="description" content="Generated by create next app" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <link rel="icon" href="/favicon.ico" /> | ||
| </Head> | ||
|
|
||
| <main className={styles.main}> | ||
| <h1 className={styles.title}> | ||
| Welcome to <a href="https://nextjs.org">Next.js!</a> | ||
| </h1> | ||
| <div className={styles.description}> | ||
| <p> | ||
| Get started by editing | ||
| <code className={styles.code}>pages/index.js</code> | ||
| </p> | ||
| <div> | ||
| <a | ||
| href="https://vercel.com?utm_source=create-next-app&utm_medium=default-template&utm_campaign=create-next-app" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| > | ||
| By{' '} | ||
| <Image | ||
| src="/vercel.svg" | ||
| alt="Vercel Logo" | ||
| className={styles.vercelLogo} | ||
| width={100} | ||
| height={24} | ||
| priority | ||
| /> | ||
| </a> | ||
| </div> | ||
| </div> | ||
|
|
||
| <p className={styles.description}> | ||
| Get started by editing{' '} | ||
| <code className={styles.code}>pages/index.js</code> | ||
| </p> | ||
| <div className={styles.center}> | ||
| <Image | ||
| className={styles.logo} | ||
| src="/next.svg" | ||
| alt="Next.js Logo" | ||
| width={180} | ||
| height={37} | ||
| priority | ||
| /> | ||
| <div className={styles.thirteen}> | ||
| <Image | ||
| src="/thirteen.svg" | ||
| alt="13" | ||
| width={40} | ||
| height={31} | ||
| priority | ||
| /> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div className={styles.grid}> | ||
| <a href="https://nextjs.org/docs" className={styles.card}> | ||
| <h2>Documentation →</h2> | ||
| <p>Find in-depth information about Next.js features and API.</p> | ||
| <a | ||
| href="https://nextjs.org/docs?utm_source=create-next-app&utm_medium=default-template&utm_campaign=create-next-app" | ||
| className={styles.card} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| > | ||
| <h2 className={inter.className}> | ||
| Docs <span>-></span> | ||
| </h2> | ||
| <p className={inter.className}> | ||
| Find in-depth information about Next.js features and API. | ||
| </p> | ||
| </a> | ||
|
|
||
| <a href="https://nextjs.org/learn" className={styles.card}> | ||
| <h2>Learn →</h2> | ||
| <p>Learn about Next.js in an interactive course with quizzes!</p> | ||
| <a | ||
| href="https://nextjs.org/learn?utm_source=create-next-app&utm_medium=default-template&utm_campaign=create-next-app" | ||
| className={styles.card} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| > | ||
| <h2 className={inter.className}> | ||
| Learn <span>-></span> | ||
| </h2> | ||
| <p className={inter.className}> | ||
| Learn about Next.js in an interactive course with quizzes! | ||
| </p> | ||
| </a> | ||
|
|
||
| <a | ||
| href="https://github.com/vercel/next.js/tree/canary/examples" | ||
| href="https://vercel.com/templates?framework=next.js&utm_source=create-next-app&utm_medium=default-template&utm_campaign=create-next-app" | ||
| className={styles.card} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| > | ||
| <h2>Examples →</h2> | ||
| <p>Discover and deploy boilerplate example Next.js projects.</p> | ||
| <h2 className={inter.className}> | ||
| Templates <span>-></span> | ||
| </h2> | ||
| <p className={inter.className}> | ||
| Discover and deploy boilerplate example Next.js projects. | ||
| </p> | ||
| </a> | ||
|
|
||
| <a | ||
| href="https://vercel.com/new?utm_source=create-next-app&utm_medium=default-template&utm_campaign=create-next-app" | ||
| className={styles.card} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| className={styles.card} | ||
| > | ||
| <h2>Deploy →</h2> | ||
| <p> | ||
| Instantly deploy your Next.js site to a public URL with Vercel. | ||
| <h2 className={inter.className}> | ||
| Deploy <span>-></span> | ||
| </h2> | ||
| <p className={inter.className}> | ||
| Instantly deploy your Next.js site to a shareable URL | ||
| with Vercel. | ||
| </p> | ||
| </a> | ||
| </div> | ||
| </main> | ||
|
|
||
| <footer className={styles.footer}> | ||
| <a | ||
| href="https://vercel.com?utm_source=create-next-app&utm_medium=default-template&utm_campaign=create-next-app" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| > | ||
| Powered by{' '} | ||
| <span className={styles.logo}> | ||
| <Image src="/vercel.svg" alt="Vercel Logo" width={72} height={16} /> | ||
| </span> | ||
| </a> | ||
| </footer> | ||
| </div> | ||
| </> | ||
| ) | ||
| } |
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the default now so we can omit it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome will do + I'll make a PR to omit this from the create-next-app package templates as well! Also in regards to merging this PR, I think it would be best to hold off until v13.0.7 is officially released -- lmk what you think!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ijjk re: @styfle's comment below: ah, looks like this template will update itself once 13.0.7 becomes an official release -- so I'm assuming this PR is not needed!
But I'll still open the PR to omit swcMinify from the create-next-app templates!
cc: @kale-stew