Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blocking playlist requests with lowLatencyMode is set to false #3792

Merged
merged 1 commit into from Apr 19, 2021

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Apr 16, 2021

This PR will...

Fix blocking playlist requests with lowLatencyMode set to false.

Why is this Pull Request needed?

For blocking playlist requests when lowLatencyMode is set to false, the playlist will be refreshed for each part until the last part index is found, and then _HLS_msn + 1 with the same _HLS_part (last part index) will be requested one PART-TARGET (or 1 second) ahead of the expected TARGETDURATION refresh time. This will make a blocking request for the next segment update without making it so early that it fails.

Resolves issues:

Resolves #3566

Checklist

  • changes have been done against master branch, and PR does not conflict

@robwalch robwalch added this to the 1.0.2 milestone Apr 16, 2021
@robwalch robwalch added this to Top priorities in Release Planning and Backlog via automation Apr 16, 2021
@robwalch robwalch merged commit bbe24e6 into master Apr 19, 2021
@robwalch robwalch deleted the bugfix/ll-hls-playlist-zero-index-part-requests branch April 19, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Release Planning and Backlog
  
Top priorities
Development

Successfully merging this pull request may close these issues.

Failing live playlist update when lowLatencyMode = false
1 participant