Fix repeated requests for initialization segments #4452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes video-dev#4450 For live video, merging playlists did not updated non-overlapping fragments. Now, the level-helper will update any non-overlapping fragmentHint or fragments to reference existing initSegment fragments.
robwalch
approved these changes
Dec 6, 2021
This was referenced Dec 10, 2021
5 tasks
littlespex
pushed a commit
to cbsinteractive/hls.js
that referenced
this pull request
Dec 9, 2022
The test to show that src= playbacks can log width/height data was failing on Tizen. This is because Tizen was ignoring the SAR (sample aspect ratio) and showing the content at 256 pixels wide, whereas other platforms were displaying at 258 pixels wide. The point of the test was never to check a platform's support for SAR, so the video has been re-encoded to display consistently across platforms. This issue began when the test was added in PR video-dev#4435. The video file is now also much smaller than it was before (from 177kB to 37kB). Re-encoding was done with: ```sh ffmpeg \ -i test/test/assets/small.mp4.orig \ -c:v h264 -vf setsar=1:1 -crf 51 \ -c:a aac -b:a 16k \ -y test/test/assets/small.mp4 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Prevent unnecessary requests for the same initialization segment. For live video, merging playlists did not updated non-overlapping fragments. Now, the level-helper will update any non-overlapping fragmentHint or fragments to reference existing initSegment fragments.
Why is this Pull Request needed?
When multiple EXT-X-MAP support was included #3859, live playlists that include EXT-X-MAP may unnecessarily request the same initialization segment multiple times.
Are there any points in the code the reviewer needs to double check?
I'm not super familiar with LL-HLS so it took me a while to figure out I needed to also include the
fragmentHintin the update check. If there's something else missing with LL-HLS integration let me know and I can work through those issues. I've tested with the LL-HLS test streamI've verified the behavior with some internal non-LL-HLS streams. Additionally the demo LL-HLS stream no longer shows repeated requests. Additionally
npm run test:funcandnpm run test:unitpass on this branch. Otherwise I don't have a very diverse set of test cases available so if there are other areas that need testing any guidance on those tests would be appreciated.Resolves issues:
#4450
Checklist
Testing: