Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust for composer-require-checker check. #7632

Merged
merged 3 commits into from Feb 11, 2022

Conversation

sasezaki
Copy link
Contributor

To avoid conflict, I do PR into master branch

  • Added Composer\Audoload\ClassLoader into bin/composer-require-checker-config.json , it is soft dependency symbol.
  • DOMElement instead of DomElement - https://php.net/DOMElement
    to avoid composer-require-check reports false-positive,
    just did - find src/ -type f -exec sed -i -e 's/DomElement/DOMElement/g' {} \;

Before

$ composer-require-checker --config-file=$(pwd)/bin/composer-require-checker-config.json
ComposerRequireChecker 3.8.0@537138b833ab0f9ad72b667a72bece2a765e88ab
The following 2 unknown symbols were found:
+-------------------------------+--------------------+
| Unknown Symbol                | Guessed Dependency |
+-------------------------------+--------------------+
| Composer\Autoload\ClassLoader |                    |
| DomElement                    |                    |
+-------------------------------+--------------------+

After

composer-require-checker --config-file=$(pwd)/bin/composer-require-checker-config.json
ComposerRequireChecker 3.8.0@537138b833ab0f9ad72b667a72bece2a765e88ab
There were no unknown symbols found.
  • Also composer-require-checker v4 check passed.

@sasezaki sasezaki marked this pull request as draft February 11, 2022 03:13
@sasezaki sasezaki marked this pull request as ready for review February 11, 2022 03:56
@AndrolGenhald
Copy link
Collaborator

Can we add this check to composer.json scripts and CI?

to avoid composer-require-check reports false-positive,
just did - find src/ -type f -exec sed -i -e 's/DomElement/DOMElement/g' {} \;
@orklah orklah added the release:internal The PR will be included in 'Internal changes' section of the release notes label Feb 11, 2022
@orklah orklah merged commit 6c2484d into vimeo:master Feb 11, 2022
@orklah
Copy link
Collaborator

orklah commented Feb 11, 2022

Thanks!

@sasezaki sasezaki deleted the composer-require-check branch February 12, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants