Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type reconciliation breaking Context::$references_in_scope (fixes #8289). #8306

Merged
merged 4 commits into from Jul 21, 2022
Merged

Fix type reconciliation breaking Context::$references_in_scope (fixes #8289). #8306

merged 4 commits into from Jul 21, 2022

Commits on Jul 20, 2022

  1. Demonstrate flaw in type reconciliation on array references

    @ohader
    ohader committed Jul 20, 2022
    Copy the full SHA
    ac315fb View commit details
    Browse the repository at this point in the history

  2. Avoid cloning undefined array index

    @ohader
    ohader committed Jul 20, 2022
    Copy the full SHA
    6c5e5f7 View commit details
    Browse the repository at this point in the history

  3. Assert ReconcilerTest::arrayReferencesAreHandled reaches the end

    @ohader
    ohader committed Jul 20, 2022
    Copy the full SHA
    98502d4 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. Fix type reconciliation breaking Context::$references_in_scope (fixes v… 

    …imeo#8289).
    @AndrolGenhald
    AndrolGenhald committed Jul 21, 2022
    Copy the full SHA
    ba6270c View commit details
    Browse the repository at this point in the history