Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applied ArraySpreadInsteadOfArrayMergeRector (take 2) #8345

Merged
merged 4 commits into from Jul 30, 2022
Merged

Applied ArraySpreadInsteadOfArrayMergeRector (take 2) #8345

merged 4 commits into from Jul 30, 2022

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented Jul 29, 2022

No description provided.

@weirdan weirdan added the release:internal The PR will be included in 'Internal changes' section of the release notes label Jul 29, 2022
@AndrolGenhald
Copy link
Collaborator

AndrolGenhald commented Jul 30, 2022 •
edited

Does this array spread syntax have the exact same result as array_merge in all cases, including sorting, with combined string and int keys? If so, do we want to add array_merge to our ForbiddenFunctions config to ensure the array spread syntax is used everywhere consistently? Maybe we should improve ForbiddenFunctions to allow configuring a custom issue description?

@weirdan
Copy link
Collaborator Author

weirdan commented Jul 30, 2022

Does this array spread syntax have the exact same result as array_merge in all cases, including sorting, with combined string and int keys?

Not until PHP 8.1: https://wiki.php.net/rfc/array_unpacking_string_keys

@weirdan weirdan marked this pull request as ready for review July 30, 2022 03:38
@weirdan weirdan requested a review from orklah July 30, 2022 03:39
@weirdan weirdan mentioned this pull request Jul 30, 2022
Closed
@orklah orklah merged commit f5b7a56 into vimeo:master Jul 30, 2022
@orklah
Copy link
Collaborator

orklah commented Jul 30, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orklah orklah Awaiting requested review from orklah

Assignees
No one assigned
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@weirdan @AndrolGenhald @orklah