Fix type widening when Any assertion is used
#8494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen an `Any` assertion is used. Fixes vimeo#8084.
…o include mixed when handling an `Any` assertion.
orklah
added
the
release:fix
|
Thanks! The rework of assertion Matt did is indeed helpful for this kind of changes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8084
Also contains a related change to the reconcilers fast path where I believe an existing check is unnecessary.
PR targets the master branch. I have been unable to backport this to 4.x, the work done in the master branch makes this issue a lot easier to resolve.