keep literal string for simple str_replace

[kkmuffme]

Just for the simplest case, as that is helpful to avoid tons of false positives, especially with callbacks that are created dynamically from paths

As discussed in #8611 (comment)

[kkmuffme]

@orklah the failing tests seem completely unrelated to the changes? Already not sure why DirnameTest.php showed up in CI , I didn't even change that (but I fixed it now anyways). But now more and more unrelated stuff shows up. Are the tests in master branch working?

[mcaskill]

Thanks for the CS fix of addslashes on DirnameTest.
As for str_replace and str_ireplace, that's a nice and simple solution.

[orklah]

yeah, circleCI is sometimes broken on PR, I'm not sure exactly why, but it happens without fault by the author so I'm merging anyway when I don't see obvious issues. It let some CS issues on master.

About that, you have one of your own right now :)

FILE: ...nal/Provider/ReturnTypeProvider/StrReplaceReturnTypeProvider.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 59 | WARNING | Line exceeds 120 characters; contains 127 characters
----------------------------------------------------------------------

LGTM after that!

[kkmuffme]

Fixed, ready to merge (missed that, bc I pushed a minor change that created that one)

[orklah]

Thanks!