Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type of ReflectionExtension::getVersion #8655

Merged
merged 2 commits into from Nov 7, 2022

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Nov 3, 2022

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@psalm-github-bot
Copy link

I found these snippets:

https://psalm.dev/r/46f74f168a
<?php

$ext = new \ReflectionExtension('ext');
$prettyVersion = $ext->getVersion();
if ($prettyVersion === null) {
    echo "Version is null\n";
}
Psalm output (using commit 8fc499e):

ERROR: TypeDoesNotContainNull - 5:5 - string does not contain null

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Nov 3, 2022
@orklah
Copy link
Collaborator

orklah commented Nov 3, 2022

Thanks for this!

You'll also need to change the Callmap_historical file that should match with Callmap (when there are no change of signature in recent PHP versions)

…hp as well

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@orklah orklah merged commit f630a0d into vimeo:4.x Nov 7, 2022
@orklah
Copy link
Collaborator

orklah commented Nov 7, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants