Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parameter types to be contained by a class template type #8731

Merged
merged 3 commits into from Nov 23, 2022

Conversation

danog
Copy link
Collaborator

@danog danog commented Nov 22, 2022

... in template function calls.

Not sure why the original logic checked for equality (in a weird way by actually checking A⊆B and B⊆A, not by actually running B==A with equals).

Fixes #8732

@danog danog marked this pull request as ready for review November 22, 2022 11:28
@danog danog changed the title Allow parameter types to be contained by a class template type in fun… Allow parameter types to be contained by a class template type Nov 22, 2022
@danog danog added the release:fix The PR will be included in 'Fixes' section of the release notes label Nov 22, 2022
@orklah
Copy link
Collaborator

orklah commented Nov 22, 2022

I never understood what's going on here. @muglug could you review this one?

@muglug muglug merged commit 54db596 into vimeo:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Literal 'foo' is not in string when using templated parameter types
3 participants