Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow parameter types to be contained by a class template type #8731

Merged
merged 3 commits into from Nov 23, 2022
Merged

Allow parameter types to be contained by a class template type #8731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73daa6f
Allow parameter types to be contained by a class template type in fun…
danog Nov 22, 2022
d4755b1
Specify PHP version of tests
danog Nov 22, 2022
314280d
Fix tests
danog Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/Psalm/Internal/Analyzer/Statements/Expression/CallAnalyzer.php
View file
Open in desktop
Expand Up @@ -1096,10 +1096,6 @@ public static function checkTemplateResult(
$statements_analyzer->getCodebase(),
$lower_bound->type,
$bound_with_equality->type
) && UnionTypeComparator::isContainedBy(
$statements_analyzer->getCodebase(),
$bound_with_equality->type,
$lower_bound->type
)) {
continue 2;
}
Expand Down
41 changes: 41 additions & 0 deletions tests/Template/FunctionTemplateTest.php
View file
Open in desktop
Expand Up @@ -1621,6 +1621,47 @@ function foo(?float $p): ?float
return $p - 1;
}'
],
'literalIsAlwaysContainedInString' => [
'code' => '<?php
/**
* @template T
*/
interface Norm
{
/**
* @param T $input
* @return T
*/
public function normalize(mixed $input): mixed;
}

/**
* @implements Norm<string>
*/
class StringNorm implements Norm
{
public function normalize(mixed $input): mixed
{
return strtolower($input);
}
}

/**
* @template TNorm
*
* @param TNorm $value
* @param Norm<TNorm> $n
*/
function normalizeField(mixed $value, Norm $n): void
{
$n->normalize($value);
}

normalizeField("foo", new StringNorm());',
'assertions' => [],
'ignored_issues' => [],
'php_version' => '8.0'
]
];
}

Expand Down