feat: supports http2 #793
Merged
feat: supports http2 #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing in the CI because of I commented the following away in my forked repository. The tests passed: https://github.com/lamweili/supertest/actions/runs/3177809614 |
This was referenced Oct 4, 2022
Closed
|
Thanks, @titanism! PS: You might want to close the following issues/PRs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
superagent@8.xalready hashttp2support.This PR enables the
http2support onsupertestas well.As this is a new feature (backward compatible and non-breaking), following
semver, a minor version jump is required.Tests are using Node.js native
http2module to create the server with 100% test coverage.http2tests are not usingexpress(asexpress@4.xdoes not supporthttp2)supertestshould not be reliant onexpressanyway