Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: automatic file: protocol handling #167

Merged
merged 9 commits into from Dec 6, 2022

Conversation

dominikg
Copy link
Collaborator

@dominikg dominikg commented Dec 5, 2022

only do it for existing directories and use relative path

  • use more specific local directory check and make sure the path is absolute
  • use pnpm 7.18.1 for ecosystem-ci itself
  • change packageManager constraint in package.json of test project if it would use pnpm 7.18.0

@dominikg
Copy link
Collaborator Author

dominikg commented Dec 5, 2022

see pnpm/pnpm#5754. if that does not get resolved quickly, we'll have to figure out how to enforce staying on 7.17

@dominikg
Copy link
Collaborator Author

dominikg commented Dec 6, 2022

updated the implementation here to avoid pnpm 7.18.0 , see https://github.com/vitejs/vite-ecosystem-ci/actions/runs/3629527374/jobs/6121834438#step:8:406

@patak-dev patak-dev merged commit 4b61cdb into main Dec 6, 2022
@patak-dev patak-dev deleted the fix/use-relative-file-override branch December 6, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants