fix: automatic file: protocol handling

.github/workflows/ci.yml

@@ -18,6 +18,7 @@ jobs:
         with:
           node-version: 18
       - run: corepack enable
+      - run: pnpm --version
       - uses: actions/setup-node@v3
         with:
           node-version: 18

.github/workflows/ecosystem-ci-from-pr.yml

@@ -92,6 +92,7 @@ jobs:
           deno-version: v1.x
         continue-on-error: true
       - run: corepack enable
+      - run: pnpm --version
       - run: pnpm i --frozen-lockfile
       - run: >-
           pnpm tsx ecosystem-ci.ts
@@ -137,6 +138,7 @@ jobs:
           deno-version: v1.x
         continue-on-error: true
       - run: corepack enable
+      - run: pnpm --version
       - run: pnpm i --frozen-lockfile
       - run: >-
           pnpm tsx ecosystem-ci.ts

.github/workflows/ecosystem-ci-selected.yml

@@ -69,6 +69,7 @@ jobs:
         id: setup-deno
         continue-on-error: true
       - run: corepack enable
+      - run: pnpm --version
       - run: pnpm i --frozen-lockfile
       - run: >-
           pnpm tsx ecosystem-ci.ts

.github/workflows/ecosystem-ci.yml

@@ -72,6 +72,7 @@ jobs:
         id: setup-deno
         continue-on-error: true
       - run: corepack enable
+      - run: pnpm --version
       - run: pnpm i --frozen-lockfile
       - run: >-
           pnpm tsx ecosystem-ci.ts

package.json

@@ -23,11 +23,11 @@
       "eslint"
     ]
   },
-  "packageManager": "pnpm@7.17.1",
+  "packageManager": "pnpm@7.18.1",
   "type": "module",
   "engines": {
     "node": ">=18",
-    "pnpm": "^7.17.1"
+    "pnpm": "^7.18.1"
   },
   "repository": {
     "type": "git",

utils.ts

@@ -339,19 +339,33 @@ export async function bisectVite(
 	}
 }
 
+function isLocalOverride(v: string): boolean {
+	if (!v.includes('/') || v.startsWith('@')) {
+		// not path-like (either a version number or a package name)
+		return false
+	}
+	try {
+		return !!fs.lstatSync(v)?.isDirectory()
+	} catch (e) {
+		if (e.code !== 'ENOENT') {
+			throw e
+		}
+		return false
+	}
+}
 export async function applyPackageOverrides(
 	dir: string,
 	pkg: any,
 	overrides: Overrides = {},
 ) {
-	const prependFileProtocol = (v: string) =>
-		fs.existsSync(v) ? `file:${v}` : v
+	const useFileProtocol = (v: string) =>
+		isLocalOverride(v) ? `file:${path.resolve(v)}` : v
 	// remove boolean flags
 	overrides = Object.fromEntries(
 		Object.entries(overrides)
 			//eslint-disable-next-line @typescript-eslint/no-unused-vars
 			.filter(([key, value]) => typeof value === 'string')
-			.map(([key, value]) => [key, prependFileProtocol(value as string)]),
+			.map(([key, value]) => [key, useFileProtocol(value as string)]),
 	)
 	await $`git clean -fdxq` // remove current install
 
@@ -363,6 +377,19 @@ export async function applyPackageOverrides(
 	const pm = agent?.split('@')[0]
 
 	if (pm === 'pnpm') {
+		const version = await $`pnpm --version`
+		// avoid bug with absolute overrides in pnpm 7.18.0
+		if (version === '7.18.0') {
+			console.warn(
+				'detected pnpm@7.18.0, changing pkg.packageManager and pkg.engines.pnpm to enforce use of pnpm@7.18.1',
+			)
+			// corepack reads this and uses pnpm 7.18.1 then
+			pkg.packageManager = 'pnpm@7.18.1'
+			if (!pkg.engines) {
+				pkg.engines = {}
+			}
+			pkg.engines.pnpm = '7.18.1'
+		}
 		if (!pkg.devDependencies) {
 			pkg.devDependencies = {}
 		}