chore: check and build if outputDir does not exist before preview #11579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenfan0
changed the title
bluwy
reviewed
Jan 5, 2023
| const distDir = path.resolve(config.root, config.build.outDir) | ||
| const isAlreadyBuild = fs.existsSync(distDir) | ||
| if (!isAlreadyBuild) { | ||
| const { status, error } = spawn.sync('npx', ['vite', 'build']) |
There was a problem hiding this comment.
I don't think we should execute vite build within preview. It feels a bit too automatic, and doesn't work for metaframeworks that use preview API but has a different build command too.
I think for now it's better to leave it as-is. If we really want to check, we could see if any plugins implement configurePreviewServer before issuing the warning. We might also want to do that if it's running through the vite preview command, as using the preview API, the consumer could adjust previewServer.httpServer themselves.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the build operation has not been performed before the preview, the preview server cannot return the corresponding file
Learn in #10564 , throwing an Error where there was none thrown before, and it breaks plugins using configurePreviewServer to customize.
So if preview, outputDir does not exist. Then it will try to execute
vite buildto build, if there is an error during the build process, it will remind the user as followsWhat is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).