docs: improve wildcard host note #8634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that this may end up confusing more users. There are a lot of details and warnings we could add. @sodatea would it be ok if we remove this warning from the CLI and document it in the docs as this PR is doing? As it was explained in the comment that triggered this issue, it will be normal in docker setups. |
|
🤦♂️ Seems no perfect solution here. IMO we can remove the CLI output for now. If there're still many people getting confused and opening issues, then it's not an edge case, we can then add it back. |
9 tasks
bluwy
reviewed
Jun 17, 2022
9 tasks
sapphi-red
commented
Jun 18, 2022
docs/config/server-options.md
Outdated
Comment on lines
17
to
19
| The first case is when `localhost` is used. Node.js below v17 reorders the result of resolved address by default. This means the resolved address might differ from the original result from DNS. When accessing `localhost`, browsers use DNS to resolve the address and that address might differ from the address which Vite is listening. | ||
|
|
||
| You could set [`dns.setDefaultResultOrder('verbatim')`](https://nodejs.org/docs/latest-v18.x/api/dns.html#dnssetdefaultresultorderorder) to disable the reordering behavior. Or you could set `server.host` to `127.0.0.1` explicitly. |
bluwy
reviewed
Jun 18, 2022
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
bluwy
approved these changes
Jun 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#8543 (comment)
I didn't add an option to hide this note because it is not so long and there is no other option to hide messages.
If we are adding an option, I think we need to think of #1728 instead.
TODO
related discord discussion
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).