JSON reporter shows incorrect status with skipped tests

[brzezinskimarcin]

Describe the bug

Whenever you have a test file with tests, that are skipped, json reporter treats the test suite as failed (even if all tests that are executed pass). This is not the case for other reporters.

For the following test file:

import { it, expect } from 'vitest'

it('2 + 3 = 5', () => {
  expect(2 + 3).toBe(5)
})

it.skip('3 + 3 = 6', () => {
  expect(3 + 3).toBe(6)
})

it returns:

{
  "numTotalTestSuites": 1,
  "numPassedTestSuites": 1,
  "numFailedTestSuites": 0,
  "numPendingTestSuites": 0,
  "numTotalTests": 2,
  "numPassedTests": 2,
  "numFailedTests": 0,
  "numPendingTests": 0,
  "numTodoTests": 0,
  "startTime": 1670029724604,
  "success": true,
  "testResults": [
    {
      "assertionResults": [
        {
          "ancestorTitles": [
            ""
          ],
          "fullName": " 2 + 3 = 5",
          "status": "passed",
          "title": "2 + 3 = 5",
          "duration": 2,
          "failureMessages": []
        },
        {
          "ancestorTitles": [
            ""
          ],
          "fullName": " 3 + 3 = 6",
          "status": "skipped",
          "title": "3 + 3 = 6",
          "failureMessages": []
        }
      ],
      "startTime": 1670029730817,
      "endTime": 1670029730819,
      "status": "failed",
      "message": "",
      "name": "/home/projects/vitest-dev-vitest-eyb3ca/test/json.test.ts"
    }
  ]
}

Note, that testResults[0].status should not be failed, because testResults[0].assertionResults contains one passed test and one skipped test.

Reproduction

https://stackblitz.com/edit/vitest-dev-vitest-eyb3ca

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 7.17.0 - /usr/local/bin/npm
  npmPackages:
    vite: latest => 3.2.4 
    vitest: latest => 0.25.3

Used Package Manager

npm

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[brzezinskimarcin]

I guess, that these are the lines, that are causing the problem. For skipped tests, t.result is undefined, but t.mode is set to skip, so we need to have more careful check there, something similar to what can be seen a couple lines above.

If someone confirms, I can make PR with the fix.