Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix playwright install #5319

Merged
merged 8 commits into from Mar 1, 2024
Merged

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Mar 1, 2024

Description

It looks like pnpx (equivalent to pnpm dlx) is downloading a latest playwright version which doesn't match with the ones listed in Vitest monorepo dependencies.

It seems pnpx is considered deprecated (see https://stackoverflow.com/a/70266473), so I replaced with a explicit variant of pnpm exec, which always uses locally installed version of cli.

For pnpm exec playwright ... to work at the root, the dependency needs to be at the root, so I moved the one from test/ui/package.json to the root package.json.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit a14b648
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65e135d5bdf88b00082cb7c0

@hi-ogawa hi-ogawa changed the title (WIP) ci: investigate playwright issue ci: fix playwright install Mar 1, 2024
@hi-ogawa hi-ogawa marked this pull request as ready for review March 1, 2024 01:58
@AriPerkkio AriPerkkio merged commit e4f2cec into vitest-dev:main Mar 1, 2024
19 checks passed
@hi-ogawa hi-ogawa deleted the ci-fix-playwright branch March 1, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants