Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: patch tsc to not crash on composite project errors #3176

Closed
wants to merge 1 commit into from
Closed

fix: patch tsc to not crash on composite project errors #3176

wants to merge 1 commit into from

Commits on May 12, 2023

  1. fix: patch tsc to not crash on composite project errors 

    Fixes vuejs#2622

I don't know the exact detail of the crash, but I find that tsc crashed
because the `diagnostic.file` object is somehow missing a `resolvedPath`
field. Meanwhile, the `fileName` field is always present. So I just
added a fallback to `fileName` in the patch.

Maybe related: microsoft/TypeScript#54057

I only add it to the 5.0 branch because I haven't tested it on 4.x,
so let's play it safe.
    @sodatea
    sodatea committed May 12, 2023
    Configuration menu
    Copy the full SHA
    5dd3a1a View commit details
    Browse the repository at this point in the history