feat: support esm ssr build #707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
commented
Jun 3, 2022
abbassabb
reviewed
Jun 5, 2022
brc-dd
added a commit
that referenced
this pull request
Jun 23, 2022
brc-dd
added a commit
that referenced
this pull request
Jun 23, 2022
|
close in favor of #856 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Vite v3 we now default to emit ESM build for SSR. This PR enables the ability it uses ESM build when available and fallback to CJS build when it's in Vite v2.
So we don't need this workaround in Vite 3
https://github.com/vitejs/vite/blob/f8c92d1f4c1bddb6c29cfd4753079157c4d96922/docs/vite.config.ts#L4-L6