Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly calculate cacheIdentifier from lockfiles #5113

Merged
merged 3 commits into from Jan 30, 2020
Merged

fix: correctly calculate cacheIdentifier from lockfiles #5113

merged 3 commits into from Jan 30, 2020

Commits on Jan 28, 2020

  1. fix: correctly calculate cacheIdentifier from lockfiles 

    follow up of vuejs#3865
fixes vuejs#4438
    @sodatea
    sodatea committed Jan 28, 2020
    Copy the full SHA
    dbce88b View commit details
    Browse the repository at this point in the history

  2. Revert "fix: correctly calculate cacheIdentifier from lockfiles" 

    This reverts commit dbce88b.
    @sodatea
    sodatea committed Jan 28, 2020
    Copy the full SHA
    3eb5c40 View commit details
    Browse the repository at this point in the history

  3. fix: should take all configFiles and lockfiles into account 

    The previous implementation is based on the assumption that config files
have precendences, e.g. `.eslintrc.js` will take higher precendence
over `.eslintrc`, and only one will take effect.

This is not accurate however. For example, babel relies on both babel
config and browserslist config, so we need to deal with 2 config files.
    @sodatea
    sodatea committed Jan 28, 2020
    Copy the full SHA
    be4ac6d View commit details
    Browse the repository at this point in the history