Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic directive arguments #9373

Merged
merged 7 commits into from
Jan 26, 2019
Merged

Dynamic directive arguments #9373

merged 7 commits into from
Jan 26, 2019

Conversation

yyx990803
Copy link
Member

Implementation per vuejs/rfcs#4

@codecov-io
Copy link

codecov-io commented Jan 26, 2019

Codecov Report

Merging #9373 into dev will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #9373      +/-   ##
==========================================
- Coverage   97.34%   97.29%   -0.05%     
==========================================
  Files         107      108       +1     
  Lines        4551     4583      +32     
==========================================
+ Hits         4430     4459      +29     
- Misses        121      124       +3
Impacted Files Coverage Δ
src/compiler/helpers.js 100% <100%> (ø) ⬆️
src/compiler/codegen/events.js 100% <100%> (ø) ⬆️
src/core/instance/render-helpers/index.js 100% <100%> (ø) ⬆️
src/compiler/codegen/index.js 100% <100%> (ø) ⬆️
src/compiler/parser/index.js 98.89% <100%> (ø) ⬆️
.../core/instance/render-helpers/bind-dynamic-keys.js 100% <100%> (ø)
src/core/instance/render-helpers/check-keycodes.js 70% <0%> (-30%) ⬇️
src/core/vdom/helpers/normalize-scoped-slots.js 94.11% <0%> (-0.33%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f219bed...8b8921b. Read the comment docs.

@yyx990803 yyx990803 added this to In progress in 2.6 Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2.6
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants