errors: change timeout errors from 408 to 500 HTTP status code #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst it is logically correct to use 408 for the timeout and script timeout errors, it causes a collision with HTTP semantics implement in HTTP clients. To support Keep-Alive we allow retries in HTTP clients and if a client sees code 408 it thinks that the server has gone away and retries the request. This causes Execute Script, Navigate To, and Refresh commands to be sent twice with some HTTP clients. This is a backwards incompatible change to WebDriver in order to not break HTTP/1.1 Keep-Alive. Fixes: #1287
andreastt
requested review from
AutomatedTester,
jgraham and
shs96c
as code owners
|
This change is backwards incompatible but we need a fix for this in order to support Keep-Alive and persistent connections. This PR can’t land until we have tests ready and I will supply these downstream in https://bugzilla.mozilla.org/show_bug.cgi?id=1484941. |
AutomatedTester
approved these changes
Aug 21, 2018
|
@AutomatedTester The tests have landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst it is logically correct to use 408 for the timeout and script
timeout errors, it causes a collision with HTTP semantics implement
in HTTP clients. To support Keep-Alive we allow retries in HTTP
clients and if a client sees code 408 it thinks that the server has
gone away and retries the request.
This causes Execute Script, Navigate To, and Refresh commands to
be sent twice with some HTTP clients.
This is a backwards incompatible change to WebDriver in order to
not break HTTP/1.1 Keep-Alive.
Fixes: #1287