Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no-floating-promises #113

Merged
merged 4 commits into from Jul 4, 2019
Merged

Add no-floating-promises #113

merged 4 commits into from Jul 4, 2019

Conversation

yamadayuki
Copy link
Collaborator

@yamadayuki yamadayuki commented Jul 2, 2019 •
edited

WHY & WHAT

To close #110

Introduce @typescript-eslint/no-floating-promises.
I'm worried about inferring the parserOptions.project property. This might overwrite the .eslintrc.parserOptions property and it'll be confusing... But the @typescript-eslint/no-floating-promises requires the parserOptions.project property.

Error: Error while loading rule '@typescript-eslint/no-floating-promises': You have used a rule which requires parserServices to be generated. You must therefore provide a value for the "parserOptions.project" property for @typescript-eslint/parser.

c.f. https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/parser#configuration

@yamadayuki yamadayuki changed the title [WIP] Add no-floating-promises Add no-floating-promises Jul 3, 2019
@yamadayuki
Copy link
Collaborator Author

@KentoMoriwaki Please review on it

@yamadayuki yamadayuki added the enhancement New feature or request label Jul 3, 2019
@yamadayuki yamadayuki merged commit a5427fb into master Jul 4, 2019
@yamadayuki yamadayuki deleted the yamadayuki/no-floating-promises branch July 4, 2019 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KentoMoriwaki KentoMoriwaki KentoMoriwaki approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add no-floating-promises as default rule
2 participants
@yamadayuki @KentoMoriwaki