Set null as the default value of deviceProperties in PointerEventInit #46174
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the default for deviceProperties in PointerEventInit was undefined; although in chromium a value was set using the default constructor. This CL changes this behaviour such that the default value for deviceProperties is null. The corresponding WPT is updated as well. For further context, please see the discussion here: w3c/pointerevents#495 (comment) Bug: 330760871 Change-Id: I5becf25f76e8b8c4572a783bfba8c1c4f36f8a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526091 Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1298623}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5526091
branch
from
63a1385
to
abcaa8d
Compare
wpt-pr-bot
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the default for deviceProperties in PointerEventInit was
undefined; although in chromium a value was set using the default
constructor. This CL changes this behaviour such that the default value
for deviceProperties is null. The corresponding WPT is updated as well.
For further context, please see the discussion here:
w3c/pointerevents#495 (comment)
Bug: 330760871
Change-Id: I5becf25f76e8b8c4572a783bfba8c1c4f36f8a74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526091
Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298623}