Add StylableSelect testdriver reftests to lint ignore #46239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5536157
branch
from
226a372
to
66800f7
Compare
testdriver is not supported in reftests: #13183 #46119 These tests need to use testdriver in reftests, so I am adding them to the lint ignore file. These tests are still worth keeping not only for future support but because they work properly when run with run_web_tests.py. Bug: 40146374 Change-Id: I73d02e5ead3c2dd4c84300e78f6502357dd7524b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5536157 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Weizhong Xia <weizhong@google.com> Reviewed-by: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1300910}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5536157
branch
from
66800f7
to
05188fe
Compare
wpt-pr-bot
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testdriver is not supported in reftests:
#13183
#46119
These tests need to use testdriver in reftests, so I am adding them to
the lint ignore file. These tests are still worth keeping not only for
future support but because they work properly when run with
run_web_tests.py.
Bug: 40146374
Change-Id: I73d02e5ead3c2dd4c84300e78f6502357dd7524b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5536157
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Weizhong Xia <weizhong@google.com>
Reviewed-by: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1300910}