Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types for services #5337

Merged
merged 5 commits into from Apr 29, 2020

Conversation

pako88
Copy link
Member

@pako88 pako88 commented Apr 29, 2020

Proposed changes

Fixed Types for services.

Without this fix:
If you import a simple custom service class (without an own package) like described here https://webdriver.io/docs/customservices.html on a TypeScript project it will fail due that the service isn't a string.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good catch!

@christian-bromann christian-bromann added PR: Docs 📝 PRs that contain changes to the documentation PR: Bug Fix 🐛 PRs that contain bug fixes and removed PR: Docs 📝 PRs that contain changes to the documentation labels Apr 29, 2020
@christian-bromann christian-bromann merged commit 96875b3 into webdriverio:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants