devtools: fix import of devices

[erwinheitzman]

Proposed changes

Fixes #5368

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

Checklist

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• I have added proper type definitions for new commands (if appropriate)

Reviewers: @webdriverio/project-committers

[christian-bromann]

I am curious if one of the test should have failed in cases this import fails.

[christian-bromann]

Ahh, there we go. I guess the actual problem was that Puppeteer updated with a breaking change which users picked up automatically.

[vitalyiegorov]

Same errors occurs with devtools: 6.1.11 and puppeteer-core: 3.0.2 as it has no exported field devicesMap, now everything is exported directly from var _DeviceDescriptors = require("puppeteer-core/DeviceDescriptors");

To make devtools launcher.js work this npm script fix can be applied:
"fix:devtools": "sed -e \"s/_DeviceDescriptors.devicesMap/_DeviceDescriptors/g\" -i.bak ./node_modules/devtools/build/launcher.js",

[lg-kialo]

Can confirm what @vitalyiegorov noted, this change breaks our test suite

[christian-bromann]

@vitalyiegorov @lg-kialo I can't reproduce the issue. Would you mind to clean up node_modules and package-lock.json and re-install all your capabilities? I just ran a fresh install with the devtools package and had no issues running this script:

const DevTools = require('devtools').default

;(async() => {
    const client = await DevTools.newSession({
        capabilities: { browserName: 'chrome' }
    })

    await client.navigateTo('https://www.google.com/ncr')
    console.log(await client.getTitle())

    await client.deleteSession()
})()

[lg-kialo]

I did that and it fixed it, not sure what the issue was. Could be that puppeteer was on an older version. Thanks!

[vitalyiegorov]

@christian-bromann Tried, but the issue is still here,

I have investigated the versions of the packages and it resolves to puppeteer-core:3.0.2 which exports the whole object from the module.

If you will take a look at the master version of puppeteer-core it has the same behavior, so I guess you should update the import of devicesMap to
import * as devicesMap from 'puppeteer-core/DeviceDescriptors' and it will fix the issue

[christian-bromann]

@vitalyiegorov please update your packages, your puppeteer-core version should be at 3.1.0.