Skip to content
This repository has been archived by the owner on Oct 27, 2020. It is now read-only.

Change default cache directory #64

Merged
merged 5 commits into from Apr 16, 2019

Conversation

mistic
Copy link
Collaborator

@mistic mistic commented Mar 19, 2019

This PR closes #62
It is pretty simple and only change the default cache directory.

/CC @evilebottnawi

src/index.js Outdated Show resolved Hide resolved
@alexander-akait
Copy link
Member

I am afraid it is breaking change

@mistic
Copy link
Collaborator Author

mistic commented Mar 20, 2019

@evilebottnawi what do you suggest? waiting for the next major release?

@alexander-akait
Copy link
Member

@mistic i think yes, anyway webpack@5 have built-in cache module, so i suggest see where he stored cache and send a PR using node_modules/.cache/webpack by default. Can you take care?

@mistic
Copy link
Collaborator Author

mistic commented Mar 21, 2019

@evilebottnawi I've opened the PR into the webpack repo webpack/webpack#8933

Do you think we can now merge this one here?

@alexander-akait
Copy link
Member

@mistic no need issue 👍 We should bump major version after merge, maybe exists other issue with breaking changes?

@mistic
Copy link
Collaborator Author

mistic commented Mar 21, 2019

@evilebottnawi let me try and think a little bit!

One thing I'll do is put up another PR in order to fix the build 😄

@alexander-akait
Copy link
Member

Let's rebase this PR to avoid CI problems

@alexander-akait
Copy link
Member

@mistic ping me if all done for major release and we do this

@mistic
Copy link
Collaborator Author

mistic commented Apr 15, 2019

@evilebottnawi I can't think in anything more for the moment that could be a breaking change

@alexander-akait alexander-akait merged commit fd1c6d7 into webpack-contrib:master Apr 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default cache directory
2 participants