Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use find-cache-dir in order to calculate the webpack default cache directory #8933

Merged
merged 2 commits into from Mar 23, 2019

Conversation

mistic
Copy link
Contributor

@mistic mistic commented Mar 21, 2019

This is a small PR in order to use the same behaviour to calculate the default cache dir on webpack that we are already using into the loaders. It was discussed here webpack-contrib/cache-loader#64

/CC @evilebottnawi

… defautl dir. Fallback to the os.tmp in case of a failure.
@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! It is doesn't break non standard directories

@webpack-bot
Copy link
Contributor

It looks like this Pull Request doesn't include enough test cases (based on Code Coverage analysis of the PR diff).

A PR need to be covered by tests if you add a new feature (we want to make sure that your feature is working) or if you fix a bug (we want to make sure that we don't run into a regression in future).

@mistic Please check if this is appliable to your PR and if you can add more test cases.

Read the test readme for details how to write test cases.

@sokra sokra merged commit 14d6472 into webpack:next Mar 23, 2019
@sokra
Copy link
Member

sokra commented Mar 23, 2019

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants