Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(init): init entry point fix when path is mentioned #886

Closed
wants to merge 2 commits into from
Closed

Fix(init): init entry point fix when path is mentioned #886

wants to merge 2 commits into from

Conversation

anikethsaha
Copy link
Member

@anikethsaha anikethsaha commented May 21, 2019

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?
No

If relevant, did you update the documentation?
Not Required

Summary
fix #884
Refactored the init-genereator.ts to change the entry options in the webpack config file to the one answered if the answer is not empty

Does this PR introduce a breaking change?

NA

Other information
The regex can be improved to more efficient with something like this

if(!(/(\'\'|\"\")/g.test(entryOptions))){
...
}

Changed the init-generator code to fix the entry point issue when the
entry point was answered
@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this same as in the entry questions file? We’re doing a similar check there

@anikethsaha
Copy link
Member Author

anikethsaha commented May 21, 2019

@evenstensberg we are getting entryOptions from that entry file.
I didn't understand which two same you are mentioning.

PS : I changed the step to reproduce in the issue #884 as the earlier steps were not correct.

@misterdev
Copy link
Contributor

misterdev commented May 21, 2019

Hi @anikethsaha, thanks for the PR :)

#817 is already addressing some of the issues of the init-generator and fixes #884 too

@anikethsaha
Copy link
Member Author

@misterdev that one looks good. Are you sure about the particular entry property issue #884 is addressing?. I need to test that but if you say that one is fine then we can go with that :)
Also, your review is pending for #883 this too, PTAL 👍

@misterdev
Copy link
Contributor

Yeah, it fixes the problem you reported about the custom entry point not set in the configuration :)
I would keep #884 open anyway until it is fixed

@anikethsaha
Copy link
Member Author

@misterdev let's keep that then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: 🐞init command doesnt change the entryOptions value when passed
4 participants