Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(init): init entry point fix when path is mentioned #886

Closed
wants to merge 2 commits into from
Closed

Fix(init): init entry point fix when path is mentioned #886

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
118ac1d
fix(init): refractor the init-generator to fix entry issue
anikethsaha May 21, 2019
0e762d7
Merge branch 'bugfix/init-entry-point-fix' of https://github.com/anik…
anikethsaha May 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/generators/init-generator.ts
View file
Open in desktop
Expand Up @@ -92,13 +92,11 @@ export default class InitGenerator extends Generator {
.then(
(entryOptions: object | string): Promise<{}> => {
if (typeof entryOptions === "string" && entryOptions.length > 0) {
return this.prompt([
Input("outputType", "In which folder do you want to store your generated bundles? (dist):")
]);
}
if (entryOptions !== '""') {
this.configuration.config.webpackOptions.entry = entryOptions;
if (entryOptions !== "\"\"" && entryOptions !== "\'\'") {
this.configuration.config.webpackOptions.entry = entryOptions;
}
}

return this.prompt([
Input("outputType", "In which folder do you want to store your generated bundles? (dist):")
]);
Expand Down