fix: error message of clientLogLevel #2021
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #2021 +/- ##
=======================================
Coverage 92.77% 92.77%
=======================================
Files 29 29
Lines 1149 1149
Branches 327 327
=======================================
Hits 1066 1066
Misses 79 79
Partials 4 4Continue to review full report at Codecov.
|
|
It has the reason(#1901 (comment)), but we've already had |
lib/options.json
Outdated
| @@ -389,7 +389,7 @@ | |||
| "bonjour": "should be {Boolean} (https://webpack.js.org/configuration/dev-server/#devserverbonjour)", | |||
| "ca": "should be {String|Buffer}", | |||
| "cert": "should be {String|Buffer}", | |||
| "clientLogLevel": "should be {String} and equal to one of the allowed values\n\n [ 'info', 'warn', 'error', 'debug', 'trace', 'silent' ]\n\n (https://webpack.js.org/configuration/dev-server/#devserverclientloglevel)", | |||
| "clientLogLevel": "should be {String} and equal to one of the allowed values\n\n [ 'none', 'info', 'error', 'warning' ]\n\n (https://webpack.js.org/configuration/dev-server/#devserverclientloglevel)", | |||
There was a problem hiding this comment.
The description should have warn and silent, and we should update documentation.
- [ 'none', 'info', 'error', 'warning' ]
+ [ 'none', 'silent', 'info', 'error', 'warning', 'warn' ]There was a problem hiding this comment.
Thank you.
I tried warn and silent, but it doesn't work as well 🤔 Is it intended?
There was a problem hiding this comment.
Ah~~ it's my bad. The version of webpack-dev-server in my local is old. I'll fix it.
Then can I handle to update documentation?
There was a problem hiding this comment.
Oops, yep. I confused. none and warning are going to be deprecated at the next major version, instead of silent and warn.
Edit, ty
There was a problem hiding this comment.
@sottar We've already had the updated documentation. So, I'll merge this documentation after merging this pr.
There was a problem hiding this comment.
Oh, I see. So the documentation is the latest right?
It seems different between you suggested above.
There was a problem hiding this comment.
@sottar sorry, I forgot trace...
https://github.com/webpack/webpack-dev-server/blob/master/client-src/default/utils/log.js#L5-L15
please update 🙇
|
related documentation webpack/webpack.js.org#2976 |
There was a problem hiding this comment.
Thanks, I'll update documentation on webpack/webpack.js.org#2976
|
@hiroppy Thank you~~ enjoy staying in Europe 😁 |
For Bugs and Features; did you add new tests?
Motivation / Use-Case
The error message of
clientLogLevelis not correct, so fixed it.ref. https://webpack.js.org/configuration/dev-server/#devserverclientloglevel
Breaking Changes
not breaking change
Additional Info