Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(clientLogLevel): update clientLogLevel options #2976

Merged
merged 5 commits into from Jun 12, 2019
Merged

docs(clientLogLevel): update clientLogLevel options #2976

merged 5 commits into from Jun 12, 2019

Conversation

gabemeola
Copy link
Contributor

From webpack/webpack-dev-server#1825

  • Changed none to silent
  • Changed warning to warn
  • Added trace and `debug

@gabemeola
fix(docs): update clientLogLevel options
697b518 
From webpack/webpack-dev-server#1825

* Changed `none` to `silent`
* Changed `warning` to `warn`
* Added `trace` and `debug
@gabemeola gabemeola mentioned this pull request Apr 27, 2019
Merged
6 tasks
@netlify
Copy link

netlify bot commented Apr 27, 2019 •
edited

Preview is ready

Built with commit 16d99f5

https://deploy-preview-2976--webpackjsorg-netlify.netlify.com

@gabemeola gabemeola changed the title fix(docs): update clientLogLevel options docs(clientLogLevel): update clientLogLevel options Apr 27, 2019
anshumanv
anshumanv approved these changes Apr 27, 2019
View reviewed changes
Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

hiroppy
hiroppy approved these changes Apr 27, 2019
View reviewed changes
Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@EugeneHlushko
Copy link
Member

EugeneHlushko commented May 1, 2019 •
edited

Hi @gabemeola
You changes to dev server haven't been release yet.

Please ping me when its getting released.

https://github.com/webpack/webpack-dev-server/releases

@EugeneHlushko
Copy link
Member

@evilebottnawi maybe worth doing a release?

@alexander-akait
Copy link
Member

Yes, in near future, we need revert one of commits

/cc @hiroppy can you take care about revert, no access to compute right now

@hiroppy
Copy link
Member

hiroppy commented May 1, 2019

@evilebottnawi

we need revert one of commits

Which the commit?

@alexander-akait
Copy link
Member

@hiroppy webpack/webpack-dev-server@2f7f052

webpack/webpack-dev-server#1777

It is invalid solution, now we support sockPort option for this case

@EugeneHlushko
Copy link
Member

Hi @gabemeola
No need to re-merge master time to time, we will do it before merge

@hiroppy hiroppy removed the On hold label May 17, 2019
@hiroppy hiroppy mentioned this pull request Jun 12, 2019
Merged
6 tasks
@hiroppy
Copy link
Member

hiroppy commented Jun 12, 2019 •
edited

@EugeneHlushko I want to merge this pr. Related webpack/webpack-dev-server#2021
And I'll delete none and warning when the major version is released.

hiroppy
hiroppy reviewed Jun 12, 2019
View reviewed changes
src/content/configuration/dev-server.md
@@ -175,27 +175,29 @@ webpack-dev-server --bonjour

## `devServer.clientLogLevel`

`string: 'none' | 'info' | 'error' | 'warning'`
`string: 'silent' | 'trace' | 'debug' | 'info' | 'warn' | 'error' | 'none' | 'warning'`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

related https://github.com/webpack/webpack-dev-server/blob/master/client-src/default/utils/log.js#L5-L15

@EugeneHlushko
Copy link
Member

okay lets see tests pass and we merge this

@EugeneHlushko EugeneHlushko merged commit b67ecea into webpack:master Jun 12, 2019
@EugeneHlushko
Copy link
Member

Thanks! CC @hiroppy

@hiroppy
Copy link
Member

hiroppy commented Jun 12, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroppy hiroppy hiroppy approved these changes

@rishabh3112 rishabh3112 rishabh3112 approved these changes

@anshumanv anshumanv anshumanv approved these changes

@pranshuchittora pranshuchittora pranshuchittora approved these changes

Assignees
No one assigned
Labels
Configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@gabemeola @EugeneHlushko @alexander-akait @hiroppy @rishabh3112 @anshumanv @pranshuchittora